feat: remove suffix from end column - #400
Merged
cx-lior-poterman merged 14 commits intoSep 16, 2026
Merged
Conversation
cx-julio-silva
previously approved these changes
Sep 14, 2026
cx-lior-poterman
dismissed
cx-julio-silva’s stale review
September 16, 2026 12:57
The base branch was changed.
cx-julio-silva
approved these changes
Sep 16, 2026
cx-lior-poterman
deleted the
AST-151006-remove-suffix-from-end-column
branch
September 16, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Suffixes of regexes of most rules were being considered as part of the location of the secret.
This created inconsistent EndColumn values between scans for secrets that got a new line, a ";" or '"' character at the end.
This feature removes those characters from the EndColumn value, accurately representing the end of the secret
StartColumn will still account for prefixes such as variables preceding the secret.
Checklist
I submit this contribution under the Apache-2.0 license.